From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cerbere@gmail.com>) id 1QTyCA-0008Rp-LQ
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 11:27:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cerbere@gmail.com>) id 1QTyC8-0006SQ-Vd
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 11:27:54 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:53813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cerbere@gmail.com>) id 1QTyC8-0006SL-Fl
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 11:27:52 -0400
Received: by pzk30 with SMTP id 30so2766604pzk.4
	for <qemu-devel@nongnu.org>; Tue, 07 Jun 2011 08:27:51 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DEB8CB3.8000400@freebsd.org>
References: <4DE501D2.7060505@freebsd.org>
	<69ABB818-A4BC-4E2F-ABEC-B4A4804D7B8A@web.de>
	<4DEB8CB3.8000400@freebsd.org>
From: Alexandre Raymond <cerbere@gmail.com>
Date: Tue, 7 Jun 2011 11:27:31 -0400
Message-ID: <BANLkTikWGMGP39H3k+TWc8_K7-Y7TR2Vuw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Fix build on FreeBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>, QEMU Developers <qemu-devel@nongnu.org>

Hi Nathan,

On Sun, Jun 5, 2011 at 10:03 AM, Nathan Whitehorn
<nwhitehorn@freebsd.org> wrote:
> On 06/02/11 10:01, Andreas F=C3=A4rber wrote:
>>
>> Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn:
>>
>>> Add some includes required to build qemu on FreeBSD.
>>
>> Missing Sob.
>
> Oops, I'll resubmit.
>
>>> ---
>>> bsd-user/syscall.c | =C2=A0 =C2=A02 ++
>>> iohandler.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A01 +
>>> os-posix.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A04 ++++
>>> 3 files changed, 7 insertions(+), 0 deletions(-)
>>
>> [...]
>>>
>>> diff --git a/iohandler.c b/iohandler.c
>>> index 2b82421..7266aca 100644
>>> --- a/iohandler.c
>>> +++ b/iohandler.c
>>> @@ -29,6 +29,7 @@
>>>
>>> #ifndef _WIN32
>>> #include <sys/wait.h>
>>> +#include <signal.h>
>>> #endif
>>>
>>> typedef struct IOHandlerRecord {
>>
>> This is independent of the other BSD issues (that I cannot judge) and
>> affects Darwin and Haiku as well. Did you check that with your patch Win=
32
>> does not need the header?
>>
>> Alexandre (cc'ed) posted a slightly different patch, adding it in
>> qemu-common.h instead.
Normally, the following patch should solve this particular missing
header. It's already been added to the trivial patches queue by
Stefan.
http://patchwork.ozlabs.org/patch/98325/

Alexandre