From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMLd0-0006UZ-LW for qemu-devel@nongnu.org; Tue, 17 May 2011 10:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMLcz-0003jc-OL for qemu-devel@nongnu.org; Tue, 17 May 2011 10:52:06 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:53325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMLcz-0003jU-Gx for qemu-devel@nongnu.org; Tue, 17 May 2011 10:52:05 -0400 Received: by iwl42 with SMTP id 42so567956iwl.4 for ; Tue, 17 May 2011 07:52:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 17 May 2011 15:52:04 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 01/11] Move user emulator stuff from cpu-exec.c to user-exec.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 14 May 2011 20:36, Blue Swirl wrote: > +#if defined(__i386__) > +#elif defined(__x86_64__) > +#elif defined(_ARCH_PPC) > +#elif defined(__alpha__) > +#elif defined(__sparc__) > +#elif defined(__arm__) > +#elif defined(__mc68000) > +#elif defined(__ia64) > +#elif defined(__s390__) > +#elif defined(__mips__) > +#elif defined(__hppa__) ...if we're moving this code about anyway would it be possible to split the per-host-arch specific code out into separate files? I find these source files with enormous ifdef ladders pretty hard to read. -- PMM