From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QTXEu-00010A-HU
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 06:40:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QTXEt-0006uP-7A
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 06:40:56 -0400
MIME-Version: 1.0
In-Reply-To: <1307246220-61006-1-git-send-email-cerbere@gmail.com>
References: <1307246220-61006-1-git-send-email-cerbere@gmail.com>
Date: Mon, 6 Jun 2011 11:40:53 +0100
Message-ID: <BANLkTikXxpk+1RH+JkqxTX-1hnDixYB_dg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Correct and standardize header guards in
 all header files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Sun, Jun 5, 2011 at 4:57 AM, Alexandre Raymond <cerbere@gmail.com> wrote=
:
> diff --git a/balloon.h b/balloon.h
> index d478e28..4602d85 100644
> --- a/balloon.h
> +++ b/balloon.h
> @@ -11,8 +11,8 @@
> =A0*
> =A0*/
>
> -#ifndef _QEMU_BALLOON_H
> -#define _QEMU_BALLOON_H
> +#ifndef QEMU_BALLOON_H
> +#define QEMU_BALLOON_H
>
> =A0#include "monitor.h"
>
> @@ -30,4 +30,4 @@ int do_info_balloon(Monitor *mon, MonitorCompletion cb,=
 void *opaque);
> =A0int do_balloon(Monitor *mon, const QDict *params,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0MonitorCompletion cb, void *opaque);
>
> -#endif
> +#endif /* QEMU_BALOON_H */

BALOON?

> diff --git a/darwin-user/qemu.h b/darwin-user/qemu.h
> index b6d3e6c..a426381 100644
> --- a/darwin-user/qemu.h
> +++ b/darwin-user/qemu.h
> @@ -175,4 +175,4 @@ static inline uint64_t get_int64_arg(int *i, CPUPPCSt=
ate *cpu_env)
> =A0}
> =A0#endif
>
> -#endif
> +#endif /* GEMU_H */

GEMU, looks like darwin-user/qemu.h typoed "QEMU"?

If you really want to do this, please use a script to convert the code
consistently without errors.  I don't have time to review long
error-prone patches that have no external benefit for QEMU, sorry.

Stefan