From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWrd3-0003OK-29 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 11:03:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWrcy-00032R-3l for qemu-devel@nongnu.org; Wed, 15 Jun 2011 11:03:36 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:47999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWrcx-00032A-Lt for qemu-devel@nongnu.org; Wed, 15 Jun 2011 11:03:31 -0400 Received: by pvg3 with SMTP id 3so381165pvg.4 for ; Wed, 15 Jun 2011 08:03:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1308049552-5744-3-git-send-email-kraxel@redhat.com> References: <1308049552-5744-1-git-send-email-kraxel@redhat.com> <1308049552-5744-3-git-send-email-kraxel@redhat.com> Date: Wed, 15 Jun 2011 16:03:27 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 14 June 2011 12:05, Gerd Hoffmann wrote: > From: Peter Maydell > > Implement the wakeup callback in the OHCI USBPortOps, so that when > a downstream device wakes up it correctly causes the OHCI controller > to come out of suspend. Just to let you know, this patch turns out to not be quite right: * if the port is suspended and the controller is not, we need to raise OHCI_INTR_RHSC * if the controller is suspended we need to put it into the resume state * the controller can be suspended when the port is not, so the check on s->ctl musn't be inside the port->ctrl if(). Sorry for the half-baked patch. I'll send a fixed version shortly. -- PMM