From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famcool@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH v3 03/12] VMDK: probe for monolithicFlat images
Date: Mon, 27 Jun 2011 05:43:25 +0100 [thread overview]
Message-ID: <BANLkTikcxqAHFCSDgySR7tsRiWm0ZcnGEw@mail.gmail.com> (raw)
In-Reply-To: <1309146518-8998-4-git-send-email-famcool@gmail.com>
On Mon, Jun 27, 2011 at 4:48 AM, Fam Zheng <famcool@gmail.com> wrote:
> + if (strncmp("version=1\n", p, strlen("version=1\n")) == 0 ||
> + strncmp("version=1\r\n", p, strlen("version=1\r\n")) == 0 ||
> + strncmp("version=2\n", p, strlen("version=2\n")) == 0 ||
> + strncmp("version=2\r\n", p, strlen("version=2\r\n")) == 0) {
> + return 100;
> + }
If p == end - 1 then this will run off the end of the buffer. You need to use:
strncmp("version=1\n", p, end - p);
Stefan
next prev parent reply other threads:[~2011-06-27 4:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 3:48 [Qemu-devel] [PATCH v3 00/12] Adding VMDK monolithic flat support Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 01/12] VMDK: introduce VmdkExtent Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 03/12] VMDK: probe for monolithicFlat images Fam Zheng
2011-06-27 4:43 ` Stefan Hajnoczi [this message]
2011-06-27 5:11 ` Fam Zheng
2011-06-27 5:33 ` Stefan Hajnoczi
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 04/12] VMDK: separate vmdk_open by format version Fam Zheng
2011-06-27 4:51 ` Stefan Hajnoczi
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 05/12] VMDK: add field BDRVVmdkState.desc_offset Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 06/12] VMDK: flush multiple extents Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 07/12] VMDK: move 'static' cid_update flag to bs field Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 08/12] VMDK: change get_cluster_offset return type Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 09/12] VMDK: open/read/write for monolithicFlat image Fam Zheng
2011-06-27 4:54 ` Stefan Hajnoczi
2011-06-27 7:00 ` Fam Zheng
2011-06-27 8:10 ` Stefan Hajnoczi
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 10/12] VMDK: create different subformats Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 11/12] VMDK: fix coding style Fam Zheng
2011-06-27 3:48 ` [Qemu-devel] [PATCH v3 12/12] BlockDriver: add bdrv_get_allocated_file_size() operation Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikcxqAHFCSDgySR7tsRiWm0ZcnGEw@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=famcool@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).