From: Blue Swirl <blauwirbel@gmail.com>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all header files
Date: Sun, 5 Jun 2011 18:37:04 +0300 [thread overview]
Message-ID: <BANLkTikeBgGTH+DrL72QyK8z-jJpcPgqhw@mail.gmail.com> (raw)
In-Reply-To: <1307246220-61006-1-git-send-email-cerbere@gmail.com>
On Sun, Jun 5, 2011 at 6:57 AM, Alexandre Raymond <cerbere@gmail.com> wrote:
> As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers,
> identifiers starting with an underscore are reserved.
>
> Therefore:
> 1) Rename all incorrect header guards
>
> While I'm at it:
> 2) Standardize header guards to "#ifndef SOMETHING_H"
> 3) Repeat the header guard identifier after the closing "#endif"
Nice. Could you also standardize the path component, for example
hw/xyz.h -> HW_XYZ_H, or maybe rather QEMU_HW_XYZ_H?
next prev parent reply other threads:[~2011-06-05 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 3:57 [Qemu-devel] [PATCH] Correct and standardize header guards in all header files Alexandre Raymond
2011-06-05 15:37 ` Blue Swirl [this message]
2011-06-06 9:36 ` Markus Armbruster
2011-06-06 10:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikeBgGTH+DrL72QyK8z-jJpcPgqhw@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=cerbere@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).