From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QTFOI-0006U4-5i
	for qemu-devel@nongnu.org; Sun, 05 Jun 2011 11:37:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QTFOH-0000Cb-3L
	for qemu-devel@nongnu.org; Sun, 05 Jun 2011 11:37:26 -0400
MIME-Version: 1.0
In-Reply-To: <1307246220-61006-1-git-send-email-cerbere@gmail.com>
References: <1307246220-61006-1-git-send-email-cerbere@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 5 Jun 2011 18:37:04 +0300
Message-ID: <BANLkTikeBgGTH+DrL72QyK8z-jJpcPgqhw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Correct and standardize header guards in
 all header files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Sun, Jun 5, 2011 at 6:57 AM, Alexandre Raymond <cerbere@gmail.com> wrote:
> As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers,
> identifiers starting with an underscore are reserved.
>
> Therefore:
> 1) Rename all incorrect header guards
>
> While I'm at it:
> 2) Standardize header guards to "#ifndef SOMETHING_H"
> 3) Repeat the header guard identifier after the closing "#endif"

Nice. Could you also standardize the path component, for example
hw/xyz.h -> HW_XYZ_H, or maybe rather QEMU_HW_XYZ_H?