From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famcool@gmail.com>) id 1Qb47i-0003C4-Q0
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 01:12:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famcool@gmail.com>) id 1Qb47h-00055f-Ej
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 01:12:38 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:52892)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famcool@gmail.com>) id 1Qb47g-00055Z-Vn
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 01:12:37 -0400
Received: by pwi5 with SMTP id 5so2889244pwi.4
	for <qemu-devel@nongnu.org>; Sun, 26 Jun 2011 22:12:35 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTikcxqAHFCSDgySR7tsRiWm0ZcnGEw@mail.gmail.com>
References: <1309146518-8998-1-git-send-email-famcool@gmail.com>
	<1309146518-8998-4-git-send-email-famcool@gmail.com>
	<BANLkTikcxqAHFCSDgySR7tsRiWm0ZcnGEw@mail.gmail.com>
From: Fam Zheng <famcool@gmail.com>
Date: Mon, 27 Jun 2011 13:11:54 +0800
Message-ID: <BANLkTikgc7yCnLx5Z-crJPxkAm13K8uvKQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 03/12] VMDK: probe for monolithicFlat
	images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, hch@lst.de

On Mon, Jun 27, 2011 at 12:43 PM, Stefan Hajnoczi <stefanha@gmail.com> wrot=
e:
> On Mon, Jun 27, 2011 at 4:48 AM, Fam Zheng <famcool@gmail.com> wrote:
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (strncmp("version=3D1\n", =
p, strlen("version=3D1\n")) =3D=3D 0 ||
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0strncmp("versio=
n=3D1\r\n", p, strlen("version=3D1\r\n")) =3D=3D 0 ||
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0strncmp("versio=
n=3D2\n", p, strlen("version=3D2\n")) =3D=3D 0 ||
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0strncmp("versio=
n=3D2\r\n", p, strlen("version=3D2\r\n")) =3D=3D 0) {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return 100;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>
> If p =3D=3D end - 1 then this will run off the end of the buffer. =C2=A0Y=
ou need to use:
>
> strncmp("version=3D1\n", p, end - p);
>

Won't work if (p =3D=3D end -1 and *p =3D=3D 'v'), how about check if end -=
 p
is big enough first?

--=20
Best regards!
Fam Zheng