From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54329 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q76LQ-0007DN-5d
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 09:30:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q76LP-0008RZ-1q
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 09:30:56 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:40024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q76LO-0008RO-VU
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 09:30:55 -0400
Received: by yib19 with SMTP id 19so151716yib.4
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2011 06:30:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110404214900.9761.49418.stgit@ginnungagap.bsc.es>
References: <20110404214900.9761.49418.stgit@ginnungagap.bsc.es>
Date: Tue, 5 Apr 2011 14:30:54 +0100
Message-ID: <BANLkTikiR8DUEuiv88iXaK0wuEW_qKnWCA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour
 of "disable" consistent across all backends
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Llu=EDs?= <xscript@gmx.net>
Cc: qemu-devel@nongnu.org

On Mon, Apr 4, 2011 at 10:49 PM, Llu=EDs <xscript@gmx.net> wrote:
> This patch defines the "disable" trace event state to always use the "nop=
"
> backend.
>
> As a side-effect, all events are now enabled (without "disable") by defau=
lt, as
> all backends (except "stderr") have programmatic support for dynamically
> (de)activating each trace event.
>
> In order to make this true, the "simple" backend now has a "-trace
> events=3D<file>" argument to let the user select which events must be ena=
bled from
> the very beginning.
>
> Signed-off-by: Llu=EDs Vilanova <vilanova@ac.upc.edu>
> ---
>
> Llu=EDs Vilanova (6):
> =A0 =A0 =A0trace: [ust] fix generation of 'trace.c' on events without arg=
s
> =A0 =A0 =A0trace: generalize the "property" concept in the trace-events f=
ile
> =A0 =A0 =A0trace-state: always use the "nop" backend on events with the "=
disable" keyword
> =A0 =A0 =A0trace-state: [simple] disable all trace points by default
> =A0 =A0 =A0trace-state: [simple] add "-trace events" argument to control =
initial state
> =A0 =A0 =A0trace: enable all events
>
>
> =A0docs/tracing.txt =A0| =A0 12 +-
> =A0qemu-config.c =A0 =A0 | =A0 =A05 +
> =A0qemu-options.hx =A0 | =A0 18 ++
> =A0scripts/tracetool | =A0 88 +++++-------
> =A0trace-events =A0 =A0 =A0| =A0385 ++++++++++++++++++++++++++-----------=
----------------
> =A0vl.c =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 94 ++++++++-----
> =A06 files changed, 313 insertions(+), 289 deletions(-)

Excellent, thanks for implementing this.  I'll review the patches in
detail shortly.

Stefan