From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46649 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q721m-0005PS-G6 for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:54:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q721l-0005VS-A0 for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:54:22 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:64434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q721l-0005V6-7e for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:54:21 -0400 Received: by yib19 with SMTP id 19so65224yib.4 for ; Tue, 05 Apr 2011 01:54:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1301982971-4574-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1301982971-4574-1-git-send-email-harsh@linux.vnet.ibm.com> Date: Tue, 5 Apr 2011 09:54:20 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH v3] v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Harsh Prateek Bora Cc: jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org On Tue, Apr 5, 2011 at 6:56 AM, Harsh Prateek Bora wrote: > The nwnames field in TWALK message is assumed to be >=3D0 and <=3D MAXWEL= EM > which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000 > RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk. > > v3: > - Updated if-else conditions to appropriately handle nwnames =3D 0. > > v2: > - Added check in v9fs_walk_complete as well. > > Signed-off-by: Harsh Prateek Bora > --- > =A0hw/9pfs/virtio-9p.c | =A0 =A07 +++++-- > =A0hw/9pfs/virtio-9p.h | =A0 =A02 +- > =A02 files changed, 6 insertions(+), 3 deletions(-) hw/virtio-9p.c I think you've submitted a patch against an internal tree that isn't upstre= am. Stefan