Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

[Peter Maydell <peter.maydell@linaro.org>]

On 22 April 2011 08:23, Brad Hards <bradh@frogmouth.net> wrote:
> On Friday 22 April 2011 02:01:48 Peter Maydell wrote:
>> Newer Linux kernels assume the existence of the performance counter
>> cp15 registers. Provide a minimal implementation of these registers.
>> We support no events. This should be compliant with the ARM ARM,
>> except that we don't implement the cycle counter.

> I tried to apply this to git master, and got a reject (attached). It looks
> like that area of target-arm/helper.c hasn't been touched in a while. Is it
> possible you have other changes for this? Did I miss a pre-requisite?

Works for me:
$ git pull
Already up-to-date.
$ git log --oneline -1
ec44445 target-arm: Set Invalid flag for NaN in float-to-int conversions
$ wget -O perfcounters.patch http://patchwork.ozlabs.org/patch/92423/mbox/
$ git am perfcounters.patch
Applying: target-arm: Minimal implementation of performance counters
$

Looking at your .rej file it seems to have lost the hardcoded tab
characters[*] that are in the patch; I suspect something in your mailer
is turning them back into spaces. Try downloading the patch from
patchwork instead.

[*] the tab-indents are in the existing code, the patch is removing
them for the lines it touches

-- PMM