From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42682 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q90wL-00011t-Ao for qemu-devel@nongnu.org; Sun, 10 Apr 2011 16:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q90wK-0005IX-4z for qemu-devel@nongnu.org; Sun, 10 Apr 2011 16:08:57 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:54911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q90wK-0005IR-1T for qemu-devel@nongnu.org; Sun, 10 Apr 2011 16:08:56 -0400 Received: by gyg4 with SMTP id 4so2442848gyg.4 for ; Sun, 10 Apr 2011 13:08:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1302462766-8560-1-git-send-email-aurelien@aurel32.net> Date: Sun, 10 Apr 2011 21:08:55 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Aurelien Jarno On 10 April 2011 20:23, Alexander Graf wrote: > On 10.04.2011, at 21:12, Aurelien Jarno wrote: >> Now that PPC defaults to softfloat which always provides float128 >> support, there is no need to keep two version of the code, depending if >> float128 support is available or not. Suggested by Peter Maydell. > Looks good to me, but I'd leave this to Peter's ack. I think it's a sensible (and pretty straightforward) cleanup, yes. [my bias towards emulation-accuracy means I don't really see much place for softfloat-native in a tcg qemu target, so I have no compunction about dropping support for it. :-)] Reviewed-by: Peter Maydell -- PMM