qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Konishchev <konishchev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()
Date: Wed, 15 Jun 2011 14:57:13 +0100	[thread overview]
Message-ID: <BANLkTikp9b6ZGxobiAjZqRL3+WGuTd4LxQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik0F0ukpQW-A2udgYi8Y5mpWc-ujw@mail.gmail.com>

2011/6/15 Dmitry Konishchev <konishchev@gmail.com>:
> On Wed, Jun 15, 2011 at 5:33 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> "disable caching"?
>
> Image geometry caching. I meant If I call bdrv_get_geometry() every
> time I need image geometry instead of obtaining it from bs_geometry
> variable.

Haha, sorry.  Too much caching: -drive cache=none, total_sectors
cached value, bdrv_get_geometry() cached values :).

Anyway, bdrv_getlength() will return the total_sectors value instead
of calling into raw-posix.c .bdrv_getlength().  That's why it should
be cheap.

Stefan

  reply	other threads:[~2011-06-15 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 14:50 [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated() Dmitry Konishchev
2011-06-13  8:26 ` Stefan Hajnoczi
2011-06-13  9:13   ` Dmitry Konishchev
2011-06-14  7:43     ` Dmitry Konishchev
2011-06-14 15:58       ` Stefan Hajnoczi
2011-06-15  7:38         ` Dmitry Konishchev
2011-06-15  8:39           ` Stefan Hajnoczi
2011-06-15  9:50             ` Dmitry Konishchev
2011-06-15 12:02               ` Stefan Hajnoczi
2011-06-15 13:14                 ` Dmitry Konishchev
2011-06-15 13:33                   ` Stefan Hajnoczi
2011-06-15 13:37                     ` Dmitry Konishchev
2011-06-15 13:57                       ` Stefan Hajnoczi [this message]
2011-06-16  8:10                         ` Dmitry Konishchev
2011-06-17  7:25                           ` Stefan Hajnoczi
2011-06-15 10:14   ` Dmitry Konishchev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikp9b6ZGxobiAjZqRL3+WGuTd4LxQ@mail.gmail.com \
    --to=stefanha@gmail.com \
    --cc=konishchev@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).