From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QWqar-0002po-28
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 09:57:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QWqap-00056Y-Gs
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 09:57:16 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:57850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QWqap-00056M-57
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 09:57:15 -0400
Received: by ywl41 with SMTP id 41so318533ywl.4
	for <qemu-devel@nongnu.org>; Wed, 15 Jun 2011 06:57:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTik0F0ukpQW-A2udgYi8Y5mpWc-ujw@mail.gmail.com>
References: <1307544625-22907-1-git-send-email-konishchev@gmail.com>
	<20110613082608.GA25582@stefanha-thinkpad.localdomain>
	<BANLkTimTipnCL5h-S2LYm85cAn=zSyqcGg@mail.gmail.com>
	<BANLkTimTrwLRnpqUt4XnMgYQNyQphzmphA@mail.gmail.com>
	<BANLkTimJWWLb15tNbSuEbnONV3E34QSt_A@mail.gmail.com>
	<BANLkTin-wmBn1DiriRpcK-g64fYDiv-uxA@mail.gmail.com>
	<BANLkTinRoU2pC+9ocpt_XPNpjLxtLaF8Jw@mail.gmail.com>
	<BANLkTinXFxny5E52FRR503=ZwCDSau7iNA@mail.gmail.com>
	<BANLkTintuq_dGCdVQoVUwfyJo8-FrT7Q-Q@mail.gmail.com>
	<BANLkTik65UFNMu9YfjEwX_YAaZqwEJMHxA@mail.gmail.com>
	<BANLkTinhNiEko1OVN3aiVGGd3S+ajOqrZQ@mail.gmail.com>
	<BANLkTik0F0ukpQW-A2udgYi8Y5mpWc-ujw@mail.gmail.com>
Date: Wed, 15 Jun 2011 14:57:13 +0100
Message-ID: <BANLkTikp9b6ZGxobiAjZqRL3+WGuTd4LxQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img
 convert' using bdrv_is_allocated()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Konishchev <konishchev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

2011/6/15 Dmitry Konishchev <konishchev@gmail.com>:
> On Wed, Jun 15, 2011 at 5:33 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> "disable caching"?
>
> Image geometry caching. I meant If I call bdrv_get_geometry() every
> time I need image geometry instead of obtaining it from bs_geometry
> variable.

Haha, sorry.  Too much caching: -drive cache=none, total_sectors
cached value, bdrv_get_geometry() cached values :).

Anyway, bdrv_getlength() will return the total_sectors value instead
of calling into raw-posix.c .bdrv_getlength().  That's why it should
be cheap.

Stefan