From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9a3Y-00039P-1M for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:38:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9a3W-0004Xi-KP for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:38:44 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:36690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9a3W-0004XW-HY for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:38:42 -0400 Received: by gyg4 with SMTP id 4so3101600gyg.4 for ; Tue, 12 Apr 2011 02:38:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1302552631.3589.86.camel@x201> References: <20110411192841.21414.46756.stgit@s20.home> <4DA35B0F.3040904@codemonkey.ws> <1302551871.3589.83.camel@x201> <1302552631.3589.86.camel@x201> Date: Tue, 12 Apr 2011 10:38:41 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mcb30@ipxe.org Cc: Alex Williamson , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Mon, Apr 11, 2011 at 9:10 PM, Alex Williamson wrote: > On Mon, 2011-04-11 at 13:57 -0600, Alex Williamson wrote: >> On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: >> > On 04/11/2011 02:35 PM, Alex Williamson wrote: >> > > This series replaces our current gPXE based PXE ROMs with iPXE >> > > versions from the iPXE project (http://ipxe.org). =A0This version >> > > adds ipxe to our submodules so it can be easily included in >> > > releases. =A0I'm still including a script for updating these, >> > > perhaps someone better with Makefiles can eventually adopt this >> > > to a build target. >> > > >> > > This email series is mainly for reference, there's too much >> > > renaming and replacing binary files to send out to the mailing >> > > list. =A0I'll strip out the binaries here so the rest can be >> > > reviewed. =A0For the real code, please pull: >> > > >> > > git://github.com/awilliam/qemu.git (ipxe branch) >> > > >> > > Thanks to Anthony for already setting up an ipxe mirror. >> > > Thanks, >> > >> > Looks good to me. =A0How different is this from what we've been shippi= ng? >> > Have you tested PXE boot from the builtin TFTP server and from an >> > external one (like dnsmasq)? >> >> We were shipping v0.9.9, which was tagged 10/2009. =A0There's been a gpx= e >> v1.0.0 release since then, plus the split between ipxe and gpxe. =A0I >> think Michael is hoping to have a release soon, but the code feels >> pretty stable to me as is. >> >> I've tested external booting from dhcp/tftp server for all the NICs. >> I'll make a pass through testing with the builtin server and report >> back. =A0Thanks, > > Check, tested virtio-net-pci, e1000, rtl8139, ne2k_pci, pcnet, and > i82550 using builtin server, with bootfile and tftp loaded > kernel/initrd. =A0All work. =A0Thanks, Whenever QEMU wants to merge a new iPXE build it would be nice to run the tests that Alex performed, plus: * PXELINUX (to test the PXE interface) * undionly.kpxe (to test the UNDI interface) It's fairly easy to do using the builtin DHCP/TFTP servers, but not that hard with dnsmasq either. The guest could be a Linux kernel and initramfs that boots and writes "PASS" to the serial port (or over a TCP connection). We can launch this with a timeout to catch failures or hangs. Or maybe iPXE has automated tests that we can run? Stefan