From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60744)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKliV-0004sa-19
	for qemu-devel@nongnu.org; Fri, 13 May 2011 02:19:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKliU-0005JF-2S
	for qemu-devel@nongnu.org; Fri, 13 May 2011 02:19:14 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:40666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKliT-0005JA-SZ
	for qemu-devel@nongnu.org; Fri, 13 May 2011 02:19:14 -0400
Received: by gwb19 with SMTP id 19so928952gwb.4
	for <qemu-devel@nongnu.org>; Thu, 12 May 2011 23:19:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1305233867-4367-3-git-send-email-jvrao@linux.vnet.ibm.com>
References: <1305233867-4367-1-git-send-email-jvrao@linux.vnet.ibm.com>
	<1305233867-4367-3-git-send-email-jvrao@linux.vnet.ibm.com>
Date: Fri, 13 May 2011 07:19:13 +0100
Message-ID: <BANLkTikvTiwNn404-_ndpt8s_JzVfFe-Ow@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 02/25] [virtio-9p] Change all pdu handlers
	to coroutines.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Thu, May 12, 2011 at 9:57 PM, Venkateswararao Jujjuri (JV)
<jvrao@linux.vnet.ibm.com> wrote:
> +typedef struct V9fsCoPdu {
> + =A0 =A0V9fsPDU *pdu;
> + =A0 =A0V9fsState *s;
> + =A0 =A0Coroutine *coroutine;
> +} V9fsCoPdu;

How about adding the V9fsState *s field to V9fsPDU?  Then you do not
need this new V9fsCoPdu struct and all the extracting fields/freeing
copdu.  You can use qemu_coroutine_self() if it is necessary to give
someone a reference to your coroutine.

Stefan