From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40880 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6nAr-0005vJ-If for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6nAq-0007yj-5x for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:02:45 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:64885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6nAq-0007ye-11 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:02:44 -0400 Received: by vxb41 with SMTP id 41so4955593vxb.4 for ; Mon, 04 Apr 2011 10:02:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4D99F34D.3060804@redhat.com> References: <1301930887-20705-1-git-send-email-avi@redhat.com> <20110404155917.GA13423@redhat.com> <4D99F061.1090208@codemonkey.ws> <4D99F34D.3060804@redhat.com> From: Blue Swirl Date: Mon, 4 Apr 2011 20:02:23 +0300 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: > On 04/04/2011 07:22 PM, Anthony Liguori wrote: >> >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: >>> >>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: >>>> >>>> Many PCI BARs that use the memory address space map a single MMIO regi= on >>>> into >>>> the entire BAR range. =C2=A0Introduce an API pci_register_bar_simple()= for >>>> that use >>>> case, and convert all users where this can be done trivially. >>>> >>>> This will reduce the work required to introduce a PCI memory API; it's >>>> also >>>> a nice code reduction in its own right. >>> >>> This will save some code, so >>> Acked-by: Michael S. Tsirkin >>> >>> I really hope the rest of devices will follow. >> >> How complete is this? > > I converted all devices which were easy to convert. =C2=A0There may be on= e or two > more that can be converted with additional work (and perhaps with an > additional pic_bar_get_current_address() API, and a pci_bar_set_coalescin= g() > API). =C2=A0The rest likely need to stick with the callback-based API. In my version which I sent earlier but didn't commit, also other BARs besides the first one and also tricky devices like VGA were handled. But I didn't commit it because I felt it was not going to right direction. I think the BARs should be specified in PCIDeviceInfo instead of adding more function calls. The same applies to this patch set.