From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests
Date: Fri, 15 Apr 2011 15:15:31 +0100 [thread overview]
Message-ID: <BANLkTim-u5GQ+Hn10gXuYzx0ywP0N_rSsQ@mail.gmail.com> (raw)
In-Reply-To: <1302873840-17161-3-git-send-email-pbonzini@redhat.com>
On Fri, Apr 15, 2011 at 2:24 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> +disable scsi_req_parsed(int target, int lun, int tag, int cmd, const char *cmdname, int mode, int xfer, uint64_t lba) "target %d lun %d tag %d command %d (%s) dir %d length %d lba %"PRIu64""
Tracing strings isn't possible with all trace backends, so we should
avoid it. It works fine with stderr but other trace backends may not
be in the same address space (they are unable to dereference pointers
to strings) or simply not have the ability to record variable-length
data.
For more info see the trace patches I posted earlier today.
Stefan
next prev parent reply other threads:[~2011-04-15 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 13:23 [Qemu-devel] [PATCH 0/2] add tracing of scsi requests Paolo Bonzini
2011-04-15 13:23 ` [Qemu-devel] [PATCH 1/2] allow ) in trace output string Paolo Bonzini
2011-04-15 13:24 ` [Qemu-devel] [PATCH 2/2] add tracing of scsi requests Paolo Bonzini
2011-04-15 14:15 ` Stefan Hajnoczi [this message]
2011-04-15 14:22 ` Paolo Bonzini
2011-04-15 14:32 ` Stefan Hajnoczi
2011-04-15 14:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim-u5GQ+Hn10gXuYzx0ywP0N_rSsQ@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).