From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAjo5-0004aW-21 for qemu-devel@nongnu.org; Fri, 15 Apr 2011 10:15:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAjo4-0004ON-0z for qemu-devel@nongnu.org; Fri, 15 Apr 2011 10:15:33 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:45303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAjo3-0004OJ-PQ for qemu-devel@nongnu.org; Fri, 15 Apr 2011 10:15:31 -0400 Received: by yxk8 with SMTP id 8so1413298yxk.4 for ; Fri, 15 Apr 2011 07:15:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1302873840-17161-3-git-send-email-pbonzini@redhat.com> References: <1302873840-17161-1-git-send-email-pbonzini@redhat.com> <1302873840-17161-3-git-send-email-pbonzini@redhat.com> Date: Fri, 15 Apr 2011 15:15:31 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Fri, Apr 15, 2011 at 2:24 PM, Paolo Bonzini wrote: > +disable scsi_req_parsed(int target, int lun, int tag, int cmd, const char *cmdname, int mode, int xfer, uint64_t lba) "target %d lun %d tag %d command %d (%s) dir %d length %d lba %"PRIu64"" Tracing strings isn't possible with all trace backends, so we should avoid it. It works fine with stderr but other trace backends may not be in the same address space (they are unable to dereference pointers to strings) or simply not have the ability to record variable-length data. For more info see the trace patches I posted earlier today. Stefan