qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "M. Mohan Kumar" <mohan@in.ibm.com>
Cc: rlandley@parallels.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] virtio-9p: Add Read only support for 9p export.
Date: Tue, 24 May 2011 09:51:17 +0100	[thread overview]
Message-ID: <BANLkTim085RKoR_kTTQS0zzzrhZVbR49ZQ@mail.gmail.com> (raw)
In-Reply-To: <1306221378-29904-1-git-send-email-mohan@in.ibm.com>

On Tue, May 24, 2011 at 8:16 AM, M. Mohan Kumar <mohan@in.ibm.com> wrote:
> @@ -192,6 +196,9 @@ QemuOptsList qemu_virtfs_opts = {
>         }, {
>             .name = "security_model",
>             .type = QEMU_OPT_STRING,
> +        }, {
> +            .name = "readonly",
> +            .type = QEMU_OPT_STRING,

Sorry to bug about bool again but there is a type QEMU_OPT_BOOL and it
is worth using.  You can get the value using qemu_opt_get_bool().  It
handles the parse error case when not on|off so you don't need to
duplicate that code.

Stefan

      reply	other threads:[~2011-05-24  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24  7:16 [Qemu-devel] [PATCH V2] virtio-9p: Add Read only support for 9p export M. Mohan Kumar
2011-05-24  8:51 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTim085RKoR_kTTQS0zzzrhZVbR49ZQ@mail.gmail.com \
    --to=stefanha@gmail.com \
    --cc=mohan@in.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rlandley@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).