From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCVaS-0001Uq-M1 for qemu-devel@nongnu.org; Wed, 20 Apr 2011 07:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCVaR-0000yC-Oe for qemu-devel@nongnu.org; Wed, 20 Apr 2011 07:28:48 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:63863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCVaR-0000xz-KR for qemu-devel@nongnu.org; Wed, 20 Apr 2011 07:28:47 -0400 Received: by vws17 with SMTP id 17so552931vws.4 for ; Wed, 20 Apr 2011 04:28:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110420112420.GE24035@volta.aurel32.net> References: <1303294329-22634-1-git-send-email-aurelien@aurel32.net> <1303294329-22634-2-git-send-email-aurelien@aurel32.net> <20110420112420.GE24035@volta.aurel32.net> Date: Wed, 20 Apr 2011 12:28:46 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 01/20] softfloat: fix floatx80 handling of NaN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 20 April 2011 12:24, Aurelien Jarno wrote: > The floatx80 format uses an explicit bit that should be taken into accoun= t > when converting to and from commonNaN format. > > When converting to commonNaN, the explicit bit should be removed if it is > a 1, and a default NaN should be used if it is 0. > > When converting from commonNan, the explicit bit should be added. > > Signed-off-by: Aurelien Jarno > --- > =C2=A0fpu/softfloat-specialize.h | =C2=A0 23 ++++++++++++++++------- > =C2=A01 files changed, 16 insertions(+), 7 deletions(-) > > v1 -> v2: fix wrong condition that may create an infinity instead of a > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NaN > v2 -> v3: don't change the sign of the default NaN. Reviewed-by: Peter Maydell -- PMM