From: Jordan Justen <jljusten@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching
Date: Sun, 10 Apr 2011 12:33:21 -0700 [thread overview]
Message-ID: <BANLkTim4dHGBRZaj6eNrRsuiACVvCLObrw@mail.gmail.com> (raw)
In-Reply-To: <4DA18C33.6050002@web.de>
On Sun, Apr 10, 2011 at 03:53, Jan Kiszka <jan.kiszka@web.de> wrote:
> Commit 5145b3d1cc revealed a bug in the lazy ROMD switch-back logic, but
> resolved it by breaking that feature. This approach addresses the issue
> by switching back to ROMD after a certain amount of read accesses
> without further unlock sequences.
Without this change, the code will stay in flash mode until a single
read occurs. The code sequence you are wanting to support using will
issue a read before trying to unlock again?
Actually, I suppose it will want to verify the written data before
moving on, so this does make sense.
Is the overhead of switching the modes significant enough to justify
the lazy switch-back? (If so, maybe I'll look at this for cfi01 too.)
Thanks,
-Jordan
next prev parent reply other threads:[~2011-04-10 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 20:16 [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode Jordan Justen
2011-04-09 16:35 ` Aurelien Jarno
2011-04-10 8:38 ` [Qemu-devel] " Jan Kiszka
2011-04-10 10:53 ` [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching Jan Kiszka
2011-04-10 19:33 ` Jordan Justen [this message]
2011-04-11 5:27 ` Jan Kiszka
2011-04-26 7:42 ` Jan Kiszka
2011-04-27 14:31 ` Aurelien Jarno
2011-04-10 18:29 ` [Qemu-devel] Re: [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode Jordan Justen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim4dHGBRZaj6eNrRsuiACVvCLObrw@mail.gmail.com \
--to=jljusten@gmail.com \
--cc=aurelien@aurel32.net \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).