qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions
Date: Mon, 2 May 2011 17:01:24 +0100	[thread overview]
Message-ID: <BANLkTim8rz4EuWKGm0Bqc5yG03sMho21Kw@mail.gmail.com> (raw)
In-Reply-To: <1303311120-3424-1-git-send-email-peter.maydell@linaro.org>

On 20 April 2011 15:52, Peter Maydell <peter.maydell@linaro.org> wrote:
> Move VLD/VST multiple into helper functions, as some cases can
> generate more TCG ops than the maximum per-instruction limit
> and certainly more than the recommended 20.

I've had a review comment in private email that this patch
slows down ffmpeg by a little over 4% (in a linux-user execution
run where about 5% of instructions were an affected vld/vst). So
perhaps the right approach is to increase the max-ops-per-insn limit
and update the guidance in tcg/README instead?

-- PMM

  parent reply	other threads:[~2011-05-02 16:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20 14:52 [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions Peter Maydell
2011-04-28 11:31 ` Peter Maydell
2011-05-02 16:01 ` Peter Maydell [this message]
2011-06-03 20:47   ` Aurelien Jarno
2011-06-04 10:01     ` Peter Maydell
2011-06-06  7:18     ` riku voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTim8rz4EuWKGm0Bqc5yG03sMho21Kw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).