From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGvYy-0001m6-UV for qemu-devel@nongnu.org; Mon, 02 May 2011 12:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGvYr-0000Ws-NZ for qemu-devel@nongnu.org; Mon, 02 May 2011 12:01:32 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:42588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGvYr-0000Wc-KA for qemu-devel@nongnu.org; Mon, 02 May 2011 12:01:25 -0400 Received: by iym10 with SMTP id 10so5845571iym.4 for ; Mon, 02 May 2011 09:01:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1303311120-3424-1-git-send-email-peter.maydell@linaro.org> References: <1303311120-3424-1-git-send-email-peter.maydell@linaro.org> Date: Mon, 2 May 2011 17:01:24 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org On 20 April 2011 15:52, Peter Maydell wrote: > Move VLD/VST multiple into helper functions, as some cases can > generate more TCG ops than the maximum per-instruction limit > and certainly more than the recommended 20. I've had a review comment in private email that this patch slows down ffmpeg by a little over 4% (in a linux-user execution run where about 5% of instructions were an affected vld/vst). So perhaps the right approach is to increase the max-ops-per-insn limit and update the guidance in tcg/README instead? -- PMM