From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKBxW-0000BQ-KN
	for qemu-devel@nongnu.org; Wed, 11 May 2011 12:08:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKBxV-0001KH-Gp
	for qemu-devel@nongnu.org; Wed, 11 May 2011 12:08:22 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:37295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKBxV-0001K7-EL
	for qemu-devel@nongnu.org; Wed, 11 May 2011 12:08:21 -0400
Received: by yxk8 with SMTP id 8so259691yxk.4
	for <qemu-devel@nongnu.org>; Wed, 11 May 2011 09:08:20 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTi=gZHLftiQRJqkK6ySuQEWm=y9yJw@mail.gmail.com>
References: <BANLkTikyfTE9a=dmcL3zk8nNMqv3_3vwDQ@mail.gmail.com>
	<BANLkTi=3H9g2+-c5kMr53s5zOEVXyeRpZA@mail.gmail.com>
	<m34o51o60q.fsf@blackfin.pond.sub.org>
	<BANLkTi=gZHLftiQRJqkK6ySuQEWm=y9yJw@mail.gmail.com>
Date: Wed, 11 May 2011 17:08:19 +0100
Message-ID: <BANLkTimB5h91JiTf78Edf9Uj_bLjvydqXQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] adding search to dhcp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Carl Karsten <carl@personnelware.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Wed, May 11, 2011 at 4:22 PM, Carl Karsten <carl@personnelware.com> wrot=
e:
> On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster <armbru@redhat.com> wr=
ote:
>> Stefan Hajnoczi <stefanha@gmail.com> writes:
>>
>>> On Tue, May 10, 2011 at 6:40 PM, Carl Karsten <carl@personnelware.com> =
wrote:
>>>> I would expect the syntax to look like this:
>>>>
>>>> qemu -hda 1.qcow2 -net nick -net
>>>> user,hostname=3Dqemu,search=3Dexample.com,sales.example.com
>>>
>>> Comma escaping is needed but it seems like a reasonable feature to me.
>>
>> Comma escaping is ugly:
>> -net user,hostname=3Dqemu,search=3Dexample.com,,sales.example.com
>>
>> Could we have multiple search options instead? =A0Like this:
>> -net user,hostname=3Dqemu,search=3Dexample.com,search=3Dsales.example.co=
m
>>
>
> How about:
>
> -net user,hostname=3Dqemu,search=3D"example.com,sales.example.com"

That does not work the way you'd expect:
$ echo asdf=3Dasdf,ok=3D"this,is,a,test"
asdf=3Dasdf,ok=3Dthis,is,a,test

Also, let's not get into the business of matching quotes and passing
them escaped on the shell.  That's just as ugly as escaping commas and
more work.

I think the two options are using QEMU's typical comma escaping ',,'
or specifying the option multiple times.  I'd go with comma escaping
for consistency.  I'm not aware of any other option in QEMU that is
specified multiple times.

Stefan