From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbVts-0001CL-Ph for qemu-devel@nongnu.org; Tue, 28 Jun 2011 06:52:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbVtr-000856-H6 for qemu-devel@nongnu.org; Tue, 28 Jun 2011 06:52:12 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:62871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbVtr-00082w-CS for qemu-devel@nongnu.org; Tue, 28 Jun 2011 06:52:11 -0400 Received: by pzk30 with SMTP id 30so41927pzk.4 for ; Tue, 28 Jun 2011 03:52:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1309195566-29207-1-git-send-email-stefano.stabellini@eu.citrix.com> References: <1309195566-29207-1-git-send-email-stefano.stabellini@eu.citrix.com> Date: Tue, 28 Jun 2011 11:52:09 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] qemu_ram_ptr_length: take ram_addr_t as arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefano.stabellini@eu.citrix.com Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, agraf@suse.de On 27 June 2011 18:26, wrote: > From: Stefano Stabellini > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > cpu_physical_memory_map should create a ram_addr_t address to pass to > qemu_ram_ptr_length from PhysPageDesc phys_offset. > > Remove code after abort() in qemu_ram_ptr_length. Reviewed-by: Peter Maydell Tested and confirmed this fixes vexpress and looks good to me -- thanks. -- PMM