From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOQuv-0001Ai-TE for qemu-devel@nongnu.org; Mon, 23 May 2011 04:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOQuu-0008FQ-RF for qemu-devel@nongnu.org; Mon, 23 May 2011 04:55:13 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:58836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOQuu-0008FM-N7 for qemu-devel@nongnu.org; Mon, 23 May 2011 04:55:12 -0400 Received: by iwl42 with SMTP id 42so5433965iwl.4 for ; Mon, 23 May 2011 01:55:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org> <1305906601-25324-3-git-send-email-peter.maydell@linaro.org> Date: Mon, 23 May 2011 09:55:11 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, patches@linaro.org On 23 May 2011 09:30, Markus Armbruster wrote: > Peter Maydell writes: > >> Don't warn about the default network setup that you get if no command li= ne >> -net options are specified. =C2=A0There are two cases that we would othe= rwise >> complain about: >> >> (1) board doesn't support a NIC but the implicit "-net nic" requested on= e > > Maybe such board should declare no_nic, similar to no_parallel & > friends. =C2=A0But that's out of this patch's scope. I think in the brave new qdev world this kind of thing should be handled generically by warning about any -device requested devices which couldn't be plugged into anything sensible. > This complaint is only added in the next patch, isn't it? =C2=A0I don't m= ind. It won't explicitly say "you asked for a NIC and didn't get one", but it will make the obscurer complaint "Warning: vlan 0 with no nics", because the implicit '-net user' is then not connected to anything. I was deliberately slightly vague with the comment text so it would be true both before and after the following patch :-) >> (2) CONFIG_SLIRP not set, so the implicit "-net nic" sets up a nic that >> isn't connected to anything > > This one's already there, I think. No, without this patch qemu will complain "Warning: vlan 0 is not connected to host network" if you configured with --disable-slirp. (--disable-slirp seems to have been left out of configure --help; I assume that's an oversight.) -- PMM