* [Qemu-devel] vmdk fails qemu-iotest 019 @ 2011-06-08 13:16 Kevin Wolf 2011-06-08 13:29 ` Fam Zheng 0 siblings, 1 reply; 6+ messages in thread From: Kevin Wolf @ 2011-06-08 13:16 UTC (permalink / raw) To: Feiran Zheng; +Cc: Qemu-devel Hi Fam, now that I had a VMDK patch in the queue for the first time since quite a while, I ran qemu-iotests for VMDK and I noticed that test case 019 fails. It doesn't seem to be a regression, even 0.14 and 0.13 fail it. I think you're running qemu-iotests to check your VMDK patches, so I wonder if you have already looked into this? Kevin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] vmdk fails qemu-iotest 019 2011-06-08 13:16 [Qemu-devel] vmdk fails qemu-iotest 019 Kevin Wolf @ 2011-06-08 13:29 ` Fam Zheng 2011-06-08 13:52 ` Kevin Wolf 0 siblings, 1 reply; 6+ messages in thread From: Fam Zheng @ 2011-06-08 13:29 UTC (permalink / raw) To: Kevin Wolf; +Cc: Qemu-devel Yes I noticed the failure, but it's trivial mismatch between `qemu-img create` output. The old test case has "cluster_size=65536" but I find the latest qemu-img omits this info, as the diff: -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 cluster_size=65536 +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 Is this your case too? On Wed, Jun 8, 2011 at 9:16 PM, Kevin Wolf <kwolf@redhat.com> wrote: > Hi Fam, > > now that I had a VMDK patch in the queue for the first time since quite > a while, I ran qemu-iotests for VMDK and I noticed that test case 019 > fails. It doesn't seem to be a regression, even 0.14 and 0.13 fail it. > > I think you're running qemu-iotests to check your VMDK patches, so I > wonder if you have already looked into this? > > Kevin > -- Best regards! Fam Zheng ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] vmdk fails qemu-iotest 019 2011-06-08 13:29 ` Fam Zheng @ 2011-06-08 13:52 ` Kevin Wolf 2011-06-08 14:17 ` Fam Zheng 0 siblings, 1 reply; 6+ messages in thread From: Kevin Wolf @ 2011-06-08 13:52 UTC (permalink / raw) To: Fam Zheng; +Cc: Qemu-devel Am 08.06.2011 15:29, schrieb Fam Zheng: > Yes I noticed the failure, but it's trivial mismatch between `qemu-img > create` output. The old test case has "cluster_size=65536" but I find > the latest qemu-img omits this info, as the diff: > > -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 cluster_size=65536 > +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 > > Is this your case too? No, I get real errors, pattern mismatches: [ Before this, there are some successful writes ] Testing conversion with -B TEST_DIR/t.IMGFMT.base Checking if backing clusters are allocated when they shouldn't qemu-io> 0/128 sectors allocated at offset 1 MiB qemu-io> qemu-io> 0/128 sectors allocated at offset 4.001 GiB qemu-io> Reading === IO: pattern 42 qemu-io> Pattern verification failed at offset 0, 512 bytes read 512/512 bytes at offset 0 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) qemu-io> Pattern verification failed at offset 1024, 512 bytes read 512/512 bytes at offset 1024 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) qemu-io> Pattern verification failed at offset 2048, 512 bytes [ More pattern verification errors follow ] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] vmdk fails qemu-iotest 019 2011-06-08 13:52 ` Kevin Wolf @ 2011-06-08 14:17 ` Fam Zheng 2011-06-08 14:55 ` Kevin Wolf 0 siblings, 1 reply; 6+ messages in thread From: Fam Zheng @ 2011-06-08 14:17 UTC (permalink / raw) To: Kevin Wolf; +Cc: Qemu-devel Oh, you're right, and I think there is a patch of mine related to the fail: "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" Can you test if this fixes it? On Wed, Jun 8, 2011 at 9:52 PM, Kevin Wolf <kwolf@redhat.com> wrote: > Am 08.06.2011 15:29, schrieb Fam Zheng: >> Yes I noticed the failure, but it's trivial mismatch between `qemu-img >> create` output. The old test case has "cluster_size=65536" but I find >> the latest qemu-img omits this info, as the diff: >> >> -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 cluster_size=65536 >> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 >> >> Is this your case too? > > No, I get real errors, pattern mismatches: > > > [ Before this, there are some successful writes ] > > Testing conversion with -B TEST_DIR/t.IMGFMT.base > > Checking if backing clusters are allocated when they shouldn't > > qemu-io> 0/128 sectors allocated at offset 1 MiB > qemu-io> qemu-io> 0/128 sectors allocated at offset 4.001 GiB > qemu-io> Reading > > === IO: pattern 42 > qemu-io> Pattern verification failed at offset 0, 512 bytes > read 512/512 bytes at offset 0 > 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > qemu-io> Pattern verification failed at offset 1024, 512 bytes > read 512/512 bytes at offset 1024 > 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > qemu-io> Pattern verification failed at offset 2048, 512 bytes > > [ More pattern verification errors follow ] > -- Best regards! Fam Zheng ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] vmdk fails qemu-iotest 019 2011-06-08 14:17 ` Fam Zheng @ 2011-06-08 14:55 ` Kevin Wolf 2011-06-09 9:31 ` Stefan Hajnoczi 0 siblings, 1 reply; 6+ messages in thread From: Kevin Wolf @ 2011-06-08 14:55 UTC (permalink / raw) To: Fam Zheng; +Cc: Qemu-devel Am 08.06.2011 16:17, schrieb Fam Zheng: > Oh, you're right, and I think there is a patch of mine related to the fail: > > "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" > > Can you test if this fixes it? Thanks, this works for me. However, I had to fix your patch manually, it was line wrapped. Please make sure to avoid this in future submissions (e.g. by using git send-email). I certainly won't do it manually for all 12 patches, but you can wait with resending until the series has got some review. :-) Kevin > > On Wed, Jun 8, 2011 at 9:52 PM, Kevin Wolf <kwolf@redhat.com> wrote: >> Am 08.06.2011 15:29, schrieb Fam Zheng: >>> Yes I noticed the failure, but it's trivial mismatch between `qemu-img >>> create` output. The old test case has "cluster_size=65536" but I find >>> the latest qemu-img omits this info, as the diff: >>> >>> -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 cluster_size=65536 >>> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 >>> >>> Is this your case too? >> >> No, I get real errors, pattern mismatches: >> >> >> [ Before this, there are some successful writes ] >> >> Testing conversion with -B TEST_DIR/t.IMGFMT.base >> >> Checking if backing clusters are allocated when they shouldn't >> >> qemu-io> 0/128 sectors allocated at offset 1 MiB >> qemu-io> qemu-io> 0/128 sectors allocated at offset 4.001 GiB >> qemu-io> Reading >> >> === IO: pattern 42 >> qemu-io> Pattern verification failed at offset 0, 512 bytes >> read 512/512 bytes at offset 0 >> 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> qemu-io> Pattern verification failed at offset 1024, 512 bytes >> read 512/512 bytes at offset 1024 >> 512.000000 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> qemu-io> Pattern verification failed at offset 2048, 512 bytes >> >> [ More pattern verification errors follow ] >> > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] vmdk fails qemu-iotest 019 2011-06-08 14:55 ` Kevin Wolf @ 2011-06-09 9:31 ` Stefan Hajnoczi 0 siblings, 0 replies; 6+ messages in thread From: Stefan Hajnoczi @ 2011-06-09 9:31 UTC (permalink / raw) To: Fam Zheng; +Cc: Kevin Wolf, Qemu-devel On Wed, Jun 8, 2011 at 3:55 PM, Kevin Wolf <kwolf@redhat.com> wrote: > Am 08.06.2011 16:17, schrieb Fam Zheng: >> Oh, you're right, and I think there is a patch of mine related to the fail: >> >> "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" >> >> Can you test if this fixes it? > > Thanks, this works for me. > > However, I had to fix your patch manually, it was line wrapped. Please > make sure to avoid this in future submissions (e.g. by using git > send-email). The GMail web interface *always* wraps lines, there doesn't seem to be a way to disable that. If you send it through GMail's SMTP servers with git-send-email(1) you'll be fine. Here is my .gitconfig: [sendemail] smtpserver = smtp.gmail.com smtpserverport = 587 smtpencryption = tls smtpuser = stefanha@gmail.com chainreplyto = false Stefan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-09 9:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-08 13:16 [Qemu-devel] vmdk fails qemu-iotest 019 Kevin Wolf 2011-06-08 13:29 ` Fam Zheng 2011-06-08 13:52 ` Kevin Wolf 2011-06-08 14:17 ` Fam Zheng 2011-06-08 14:55 ` Kevin Wolf 2011-06-09 9:31 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).