From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWzop-0008N9-4b for qemu-devel@nongnu.org; Wed, 15 Jun 2011 19:48:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWzon-0000Ff-9H for qemu-devel@nongnu.org; Wed, 15 Jun 2011 19:48:18 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:43686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWzom-0000FY-Im for qemu-devel@nongnu.org; Wed, 15 Jun 2011 19:48:16 -0400 Received: by pzk30 with SMTP id 30so779275pzk.4 for ; Wed, 15 Jun 2011 16:48:14 -0700 (PDT) MIME-Version: 1.0 Sender: balrogg@gmail.com In-Reply-To: <31d82fef8ae4c0a9d8d50bd4d62f45e8250a0ed9.1308070416.git.jan.kiszka@siemens.com> References: <31d82fef8ae4c0a9d8d50bd4d62f45e8250a0ed9.1308070416.git.jan.kiszka@siemens.com> Date: Thu, 16 Jun 2011 01:48:14 +0200 Message-ID: From: andrzej zaborowski Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart Reply-To: balrogg@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel On 14 June 2011 18:53, Jan Kiszka wrote: > Convert the last user of vga_dirty_log_restart to > cpu_register_physical_memory_log and drop the service. > > CC: Andrzej Zaborowski > Signed-off-by: Jan Kiszka Reviewed-by: Andrzej Zaborowski > --- > =C2=A0hw/vga.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A06 ------ > =C2=A0hw/vga_int.h =C2=A0 =C2=A0| =C2=A0 =C2=A01 - > =C2=A0hw/vmware_vga.c | =C2=A0 =C2=A05 ++--- > =C2=A03 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/hw/vga.c b/hw/vga.c > index 124295a..814d0d3 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -1606,12 +1606,6 @@ void vga_dirty_log_stop(VGACommonState *s) > =C2=A0#endif > =C2=A0} > > -void vga_dirty_log_restart(VGACommonState *s) > -{ > - =C2=A0 =C2=A0vga_dirty_log_stop(s); > - =C2=A0 =C2=A0vga_dirty_log_start(s); > -} > - > =C2=A0/* > =C2=A0* graphic modes > =C2=A0*/ > diff --git a/hw/vga_int.h b/hw/vga_int.h > index d2811bd..5cd9a6e 100644 > --- a/hw/vga_int.h > +++ b/hw/vga_int.h > @@ -196,7 +196,6 @@ void vga_common_reset(VGACommonState *s); > > =C2=A0void vga_dirty_log_start(VGACommonState *s); > =C2=A0void vga_dirty_log_stop(VGACommonState *s); > -void vga_dirty_log_restart(VGACommonState *s); > > =C2=A0extern const VMStateDescription vmstate_vga_common; > =C2=A0uint32_t vga_ioport_read(void *opaque, uint32_t addr); > diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c > index 1dfa875..82e2a1c 100644 > --- a/hw/vmware_vga.c > +++ b/hw/vmware_vga.c > @@ -1148,12 +1148,11 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev= , int region_num, > =C2=A0 =C2=A0 struct vmsvga_state_s *s =3D &d->chip; > > =C2=A0 =C2=A0 s->vram_base =3D addr; > - =C2=A0 =C2=A0cpu_register_physical_memory(s->vram_base, s->vga.vram_siz= e, > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s->vga.vram_offset | IO_MEM_RAM); > + =C2=A0 =C2=A0cpu_register_physical_memory_log(s->vram_base, s->vga.vram= _size, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s->vga.vram_offset = | IO_MEM_RAM, 0, true); > > =C2=A0 =C2=A0 s->vga.map_addr =3D addr; > =C2=A0 =C2=A0 s->vga.map_end =3D addr + s->vga.vram_size; > - =C2=A0 =C2=A0vga_dirty_log_restart(&s->vga); > =C2=A0} > > =C2=A0static void pci_vmsvga_map_fifo(PCIDevice *pci_dev, int region_num, > -- > 1.7.1 > > >