From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balrogg@gmail.com>) id 1QX2Cs-0006du-Lj
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 22:21:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <balrogg@gmail.com>) id 1QX2Cr-0001wp-63
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 22:21:18 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:51736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balrogg@gmail.com>) id 1QX2Cq-0001wg-Uy
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 22:21:17 -0400
Received: by pwi6 with SMTP id 6so379269pwi.4
	for <qemu-devel@nongnu.org>; Wed, 15 Jun 2011 19:21:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1306427651-3547-1-git-send-email-peter.maydell@linaro.org>
References: <1306427651-3547-1-git-send-email-peter.maydell@linaro.org>
Date: Thu, 16 Jun 2011 04:21:15 +0200
Message-ID: <BANLkTimRNBc4dSbhhJtcdiGRD-tjVn=HAQ@mail.gmail.com>
From: andrzej zaborowski <balrogg@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] hw/9118.c: Implement active-low interrupt
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

Hi,

On 26 May 2011 18:34, Peter Maydell <peter.maydell@linaro.org> wrote:
> The 9118 ethernet controller interrupt line is active low unless
> the IRQ config register is programmed to set both the IRQ_POL
> (polarity: active-high) and IRQ_TYPE (type: push-pull) bits:
> implement support for inverting the irq output in other configurations.
> This also requires that we support setting the bits in the first
> place, and that we correctly preserve them across software reset.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The motivation for this patch is actually an omap3 platform (overo)
> which uses the active-low configuration; the platforms in QEMU
> mainline which use it (vexpress and realview) both configure the
> chip to active-high, which is why this bug hasn't come to light
> before. I've tested that (a) my overo platform works with the
> change and (b) it doesn't regress vexpress.

I pushed this patch, thanks.

Cheers