From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54522)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFugz-0002zq-2t
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 16:53:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFugy-0008Gx-0q
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 16:53:37 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:38187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFugx-0008Gt-Uu
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 16:53:35 -0400
Received: by qyk36 with SMTP id 36so528125qyk.4
	for <qemu-devel@nongnu.org>; Fri, 29 Apr 2011 13:53:35 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1304023875-25040-3-git-send-email-rth@twiddle.net>
References: <1304023875-25040-1-git-send-email-rth@twiddle.net>
	<1304023875-25040-3-git-send-email-rth@twiddle.net>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Fri, 29 Apr 2011 23:53:15 +0300
Message-ID: <BANLkTimRwQ08ZqWaKmU9sjEkCLbkNApCYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER
 interrupts when SSTEP_NOIRQ either.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Thu, Apr 28, 2011 at 11:50 PM, Richard Henderson <rth@twiddle.net> wrote=
:
> This would affect Sparc as well.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> ---
> =C2=A0cpu-exec.c | =C2=A0 =C2=A01 +
> =C2=A01 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 395cd8c..e1b85d6 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -361,6 +361,7 @@ int cpu_exec(CPUState *env1)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if =
(unlikely(env->singlestep_enabled & SSTEP_NOIRQ)) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 /* Mask out external interrupts for this step. */
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 interrupt_request &=3D ~(CPU_INTERRUPT_HARD |
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 CPU_INTERRUPT_TIMER |

Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set,
only cleared or checked. How
about removing the flag instead?