* [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state
@ 2011-04-15 15:08 Jes.Sorensen
2011-04-15 16:36 ` Stefan Hajnoczi
2011-04-15 17:06 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Jes.Sorensen @ 2011-04-15 15:08 UTC (permalink / raw)
To: kwolf; +Cc: qemu-devel, stefanha
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
qemu-progress.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/qemu-progress.c b/qemu-progress.c
index 6498161..f3ce974 100644
--- a/qemu-progress.c
+++ b/qemu-progress.c
@@ -29,7 +29,6 @@
#include <signal.h>
struct progress_state {
- int enabled;
float current;
float last_print;
float min_skip;
@@ -46,10 +45,8 @@ static struct progress_state state;
*/
static void progress_simple_print(void)
{
- if (state.enabled) {
- printf(" (%3.2f/100%%)\r", state.current);
- fflush(stdout);
- }
+ printf(" (%3.2f/100%%)\r", state.current);
+ fflush(stdout);
}
static void progress_simple_end(void)
@@ -92,7 +89,6 @@ static void progress_dummy_init(void)
void qemu_progress_init(int enabled, float min_skip)
{
- state.enabled = enabled;
state.min_skip = min_skip;
if (enabled) {
progress_simple_init();
--
1.7.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state
2011-04-15 15:08 [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state Jes.Sorensen
@ 2011-04-15 16:36 ` Stefan Hajnoczi
2011-04-15 17:06 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-04-15 16:36 UTC (permalink / raw)
To: Jes.Sorensen; +Cc: kwolf, qemu-devel, stefanha
On Fri, Apr 15, 2011 at 4:08 PM, <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> ---
> qemu-progress.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state
2011-04-15 15:08 [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state Jes.Sorensen
2011-04-15 16:36 ` Stefan Hajnoczi
@ 2011-04-15 17:06 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2011-04-15 17:06 UTC (permalink / raw)
To: Jes.Sorensen; +Cc: qemu-devel, stefanha
Am 15.04.2011 17:08, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-15 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 15:08 [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state Jes.Sorensen
2011-04-15 16:36 ` Stefan Hajnoczi
2011-04-15 17:06 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).