From: Dmitry Konishchev <konishchev@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()
Date: Mon, 13 Jun 2011 13:13:06 +0400 [thread overview]
Message-ID: <BANLkTimTipnCL5h-S2LYm85cAn=zSyqcGg@mail.gmail.com> (raw)
In-Reply-To: <20110613082608.GA25582@stefanha-thinkpad.localdomain>
On Mon, Jun 13, 2011 at 12:26 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> The optimization is to check allocation metadata instead of
> unconditionally reading and then checking for all zeroes?
Yeah, exactly.
On Mon, Jun 13, 2011 at 12:26 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> Why introduce a new constant instead of using BDRV_SECTOR_SIZE?
OK, I'll fix this.
On Mon, Jun 13, 2011 at 12:26 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> "iff" is not a typo. It means "if and only if".
Sorry, I don't know English so good. :) Will revert this.
On Mon, Jun 13, 2011 at 12:26 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> I think the recursive is_allocated() needs its own function. This
> function is already long/complex enough :).
I haven't done this because in this case I have to pass too lot of
local variables to this function. Just not sure that it'll look
better. But if you mind I surely can do this.
--
Dmitry Konishchev
mailto:konishchev@gmail.com
next prev parent reply other threads:[~2011-06-13 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 14:50 [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated() Dmitry Konishchev
2011-06-13 8:26 ` Stefan Hajnoczi
2011-06-13 9:13 ` Dmitry Konishchev [this message]
2011-06-14 7:43 ` Dmitry Konishchev
2011-06-14 15:58 ` Stefan Hajnoczi
2011-06-15 7:38 ` Dmitry Konishchev
2011-06-15 8:39 ` Stefan Hajnoczi
2011-06-15 9:50 ` Dmitry Konishchev
2011-06-15 12:02 ` Stefan Hajnoczi
2011-06-15 13:14 ` Dmitry Konishchev
2011-06-15 13:33 ` Stefan Hajnoczi
2011-06-15 13:37 ` Dmitry Konishchev
2011-06-15 13:57 ` Stefan Hajnoczi
2011-06-16 8:10 ` Dmitry Konishchev
2011-06-17 7:25 ` Stefan Hajnoczi
2011-06-15 10:14 ` Dmitry Konishchev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimTipnCL5h-S2LYm85cAn=zSyqcGg@mail.gmail.com' \
--to=konishchev@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).