From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFWVp-0007kv-Pz
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:04:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFWVo-0006Bo-S0
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:04:29 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:34054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QFWVo-0006Bj-Pg
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:04:28 -0400
Received: by qwj8 with SMTP id 8so1671513qwj.4
	for <qemu-devel@nongnu.org>; Thu, 28 Apr 2011 12:04:28 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DB9A7E0.7080002@codemonkey.ws>
References: <1304010495-18136-1-git-send-email-weil@mail.berlios.de>
	<4DB9A644.6000802@codemonkey.ws> <4DB9A78F.3000006@mail.berlios.de>
	<4DB9A7E0.7080002@codemonkey.ws>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 28 Apr 2011 22:04:08 +0300
Message-ID: <BANLkTimUwGGoWYKWiqLJK-4No1geOdsj6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include
	statements)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Weil <Stefan.Weil@kath-kirche-ladenburg.de>, QEMU Developers <qemu-devel@nongnu.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>

On Thu, Apr 28, 2011 at 8:46 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 04/28/2011 12:44 PM, Stefan Weil wrote:
>>
>> Am 28.04.2011 19:39, schrieb Anthony Liguori:
>>>
>>> On 04/28/2011 12:08 PM, Stefan Weil wrote:
>>>>
>>>> From: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>>>
>>>> Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
>>>> without fixing the include paths.
>>>>
>>>> Signed-off-by: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>>
>>>
>>> This is not correct. I think we learned in IRC that the problem is
>>> Stefan is using CFLAGS=-g which overrides the CFLAGS append added by
>>> this patch.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>>
>> QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
>> because now users can no longer set their own CFLAGS.
>
> Use ./configure --extra-cflags="-g"

No, we should be able to override CFLAGS, because Juan made great
effort earlier to fix the logic and separate QEMU_CFLAGS and CFLAGS.
Please see a558ee17761c3c9ef22792bd5097880ab92f1bf5.