From: TeLeMan <geleman@gmail.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] piix_pci: fix piix3_set_irq_pic()
Date: Mon, 16 May 2011 19:50:55 +0800 [thread overview]
Message-ID: <BANLkTimVJAJL=2Jxe+qDMKPtS8CLagYhBA@mail.gmail.com> (raw)
If pic_irq is greater than 7, the irq level is always 0 on 32bits.
Signed-off-by: TeLeMan <geleman@gmail.com>
---
hw/piix_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 7f1c4cc..85a320e 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -312,7 +312,7 @@ static void piix3_set_irq_pic(PIIX3State *piix3,
int pic_irq)
{
qemu_set_irq(piix3->pic[pic_irq],
!!(piix3->pic_levels &
- (((1UL << PIIX_NUM_PIRQS) - 1) <<
+ (((1ULL << PIIX_NUM_PIRQS) - 1) <<
(pic_irq * PIIX_NUM_PIRQS))));
}
--
1.7.3.1.msysgit.0
--
SUN OF A BEACH
next reply other threads:[~2011-05-16 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 11:50 TeLeMan [this message]
2011-05-16 12:05 ` [Qemu-devel] [Qemu-trivial] [PATCH] piix_pci: fix piix3_set_irq_pic() Stefan Hajnoczi
2011-05-22 19:06 ` [Qemu-devel] " Michael S. Tsirkin
2011-05-22 19:18 ` Stefan Weil
2011-05-23 2:36 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimVJAJL=2Jxe+qDMKPtS8CLagYhBA@mail.gmail.com' \
--to=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).