From: Stefan Hajnoczi <stefanha@gmail.com>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] rtl8139: use TARGET_FMT_plx in debug messages
Date: Thu, 21 Apr 2011 12:16:36 +0100 [thread overview]
Message-ID: <BANLkTimVd8euSOoDtyuAqi8+SimisL3w=g@mail.gmail.com> (raw)
In-Reply-To: <1303342742-16388-1-git-send-email-benjamin.poirier@gmail.com>
On Thu, Apr 21, 2011 at 12:39 AM, Benjamin Poirier
<benjamin.poirier@gmail.com> wrote:
> Prevents a compilation failure when DEBUG_RTL8139 is defined:
>
> CC libhw32/rtl8139.o
> cc1: warnings being treated as errors
> hw/rtl8139.c: In function ‘rtl8139_cplus_transmit_one’:
> hw/rtl8139.c:1960: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 5 has type ‘target_phys_addr_t’
> make[1]: *** [rtl8139.o] Error 1
>
> Signed-off-by: Benjamin Poirier <benjamin.poirier@gmail.com>
> Cc: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
> ---
> hw/rtl8139.c | 15 +++++++++------
> 1 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-04-21 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 23:39 [Qemu-devel] [PATCH 1/3] rtl8139: use TARGET_FMT_plx in debug messages Benjamin Poirier
2011-04-20 23:39 ` [Qemu-devel] [PATCH 2/3] rtl8139: use variadic macro for debug statements Benjamin Poirier
2011-04-20 23:39 ` [Qemu-devel] [PATCH 3/3] rtl8139: add format attribute to DPRINTF Benjamin Poirier
2011-04-21 11:16 ` Stefan Hajnoczi [this message]
2011-04-25 20:49 ` [Qemu-devel] [PATCH 1/3] rtl8139: use TARGET_FMT_plx in debug messages Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimVd8euSOoDtyuAqi8+SimisL3w=g@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=benjamin.poirier@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).