From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] bdrv_img_create: Fix segfault
Date: Wed, 1 Jun 2011 23:34:52 +0100 [thread overview]
Message-ID: <BANLkTimW_uZVNOuQ-pW=S1dACymCCaaHBg@mail.gmail.com> (raw)
In-Reply-To: <1306929912-15484-1-git-send-email-kwolf@redhat.com>
On Wed, Jun 1, 2011 at 1:05 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Block drivers that don't support creating images don't have a size option. Fail
> gracefully instead of segfaulting when trying to access the option's value.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
A command-line to reproduce the crash would be nice.
I noticed this line above your fix:
set_option_parameter_int(param, BLOCK_OPT_SIZE, img_size);
If I follow correctly there should be an "Unknown option 'size'" error
message before set_option_parameter_int() returns -1 (which we ignore)
and then crash.
Perhaps we should just catch the error when set_option_parameter_int() fails?
Stefan
next prev parent reply other threads:[~2011-06-01 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 12:05 [Qemu-devel] [PATCH] bdrv_img_create: Fix segfault Kevin Wolf
2011-06-01 22:34 ` Stefan Hajnoczi [this message]
2011-06-06 10:00 ` Kevin Wolf
2011-06-06 11:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimW_uZVNOuQ-pW=S1dACymCCaaHBg@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).