From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCErV-0002fv-1L
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 13:37:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCErT-0003qR-Uw
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 13:37:17 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:41841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCErT-0003qN-RJ
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 13:37:15 -0400
Received: by vxb41 with SMTP id 41so5263441vxb.4
	for <qemu-devel@nongnu.org>; Tue, 19 Apr 2011 10:37:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1303160412-8107-18-git-send-email-aurelien@aurel32.net>
References: <1303160412-8107-1-git-send-email-aurelien@aurel32.net>
	<1303160412-8107-18-git-send-email-aurelien@aurel32.net>
Date: Tue, 19 Apr 2011 18:37:14 +0100
Message-ID: <BANLkTimWgA2dqyEYBFBX_A1eSvo4MVa2-g@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 17/20] target-i386: fix logarithmic and
 trigonometric helpers wrt softfloat
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 18 April 2011 22:00, Aurelien Jarno <aurelien@aurel32.net> wrote:
> +#include <math.h>

Why does this patch need this? I couldn't see anywhere where
the patch added calls to math functions we weren't calling before,
or did I miss one?

> =C2=A0void helper_fptan(void)
> =C2=A0{
> - =C2=A0 =C2=A0CPU86_LDouble fptemp;
> + =C2=A0 =C2=A0double fptemp =3D CPU86_LDouble_to_double(ST0);
>
> - =C2=A0 =C2=A0fptemp =3D ST0;
> =C2=A0 =C2=A0 if((fptemp > MAXTAN)||(fptemp < -MAXTAN)) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 env->fpus |=3D 0x400;
> =C2=A0 =C2=A0 } else {
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0ST0 =3D tan(fptemp);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0fptemp =3D tan(fptemp);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0ST0 =3D double_to_CPU86_LDouble(fptemp);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 fpush();
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0ST0 =3D 1.0;
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0ST0 =3D double_to_CPU86_LDouble(1.0);

You could just say:
   ST0 =3D floatx_one;

-- PMM