From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcMF7-000531-BQ
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:45:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcMF5-0001Zl-OB
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:45:37 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:48068)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcMF5-0001Zb-8b
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:45:35 -0400
Received: by pvg3 with SMTP id 3so2284322pvg.4
	for <qemu-devel@nongnu.org>; Thu, 30 Jun 2011 11:45:34 -0700 (PDT)
MIME-Version: 1.0
Sender: anthony.perard@gmail.com
In-Reply-To: <4E096B5F.7040309@redhat.com>
References: <1309192483-32468-1-git-send-email-anthony.perard@citrix.com>
	<BANLkTimHE7GxT-zB9OZR1XaprNQ-kkeciA@mail.gmail.com>
	<4E096B5F.7040309@redhat.com>
From: Anthony PERARD <anthony.perard@citrix.com>
Date: Thu, 30 Jun 2011 19:45:04 +0100
Message-ID: <BANLkTimXNcUj2RuZSQ5C4y6r80qQeeQHdA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Peter Maydell <peter.maydell@linaro.org>, QEMU-devel <qemu-devel@nongnu.org>

On Tue, Jun 28, 2011 at 06:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 06/27/2011 08:07 PM, Peter Maydell wrote:
>>
>> > =C2=A0+ =C2=A0 =C2=A0int ioport_base;
>> > =C2=A0+ =C2=A0 =C2=A0uint32_t ioport_reg[2];
>>
>> I think ioport_reg[] needs to go in the VMStateDescription as well.
>> I don't know enough about the PCI subsystem to know whether that's
>> also true of ioport_base or whether the the map function is called
>> again on a vmload.
>
> ioport_reg[1] is never written nor read, so this can be changed to a sing=
le
> uint32_t ioport_addr. =C2=A0Since it will be almost always 0 (either beca=
use it
> was never written, or because E1000_CTRL =3D=3D 0), a subsection is usefu=
l to
> have.

Indeed, I will remove ioport_reg[1] and ioport_addr.

Thanks,

--=20
Anthony PERARD