From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QSGwH-0001ON-Ac
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 19:04:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QSGwE-0006TY-T8
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 19:04:29 -0400
MIME-Version: 1.0
In-Reply-To: <BANLkTinor25LBJqAbHyqPcJW_7KzpaMhsw@mail.gmail.com>
References: <1306981290-17308-1-git-send-email-cerbere@gmail.com>
	<BANLkTi=hHCo6e0aoF1TypAb06vDN_6e+6A@mail.gmail.com>
	<BANLkTinor25LBJqAbHyqPcJW_7KzpaMhsw@mail.gmail.com>
Date: Fri, 3 Jun 2011 00:04:25 +0100
Message-ID: <BANLkTim_HCrg-uuyABYR0f3L9=JSoQ8TYQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing
 header for sigaction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-trivial@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, qemu-devel@nongnu.org

On Thu, Jun 2, 2011 at 11:55 PM, Alexandre Raymond <cerbere@gmail.com> wrote:
> Should I send a follow-up patch to remove signal.h wherever
> qemu-common.h is already included?

Yes, please.

I didn't know that qemu-common.h pulls in system headers so users
don't need to, I always figured .c files should include what they use.
 But if we use this approach we might as well update the codebase.

Stefan