From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Remove unneeded function parameter from gen_pc_load
Date: Wed, 13 Apr 2011 22:05:57 +0100 [thread overview]
Message-ID: <BANLkTim_d=CWShjgsSn7hKNo5AYqCHZAAQ@mail.gmail.com> (raw)
In-Reply-To: <1302727085-14713-1-git-send-email-weil@mail.berlios.de>
On 13 April 2011 21:38, Stefan Weil <weil@mail.berlios.de> wrote:
> gen_pc_load was introduced in commit
> d2856f1ad4c259e5766847c49acbb4e390731bd4.
> The only reason for parameter searched_pc was
> a debug statement in target-i386/translate.c.
>
> Remove searched_pc from the debug statement
> and from the parameter list of gen_pc_load.
No issues with the meat of the patch, but if we're going to
change all the callers and implementations of this anyway,
is there any appetite for giving it a more appropriate name?
It doesn't generate any code, it affects more than just the
pc, and it doesn't do a load...
restore_state_to_opc() ? set_env_for_opc() ?
-- PMM
next prev parent reply other threads:[~2011-04-13 21:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 20:38 [Qemu-devel] [PATCH] Remove unneeded function parameter from gen_pc_load Stefan Weil
2011-04-13 21:05 ` Peter Maydell [this message]
2011-04-14 18:50 ` Stefan Weil
2011-04-17 18:27 ` Aurelien Jarno
2011-04-17 21:07 ` Stefan Weil
2011-04-17 21:34 ` Peter Maydell
2011-04-17 21:43 ` Aurelien Jarno
2011-04-18 16:35 ` Stefan Weil
2011-04-18 16:39 ` [Qemu-devel] [PATCH 1/2] Remove unused function parameters from gen_pc_load and rename the function Stefan Weil
2011-04-18 17:15 ` Peter Maydell
2011-04-20 9:03 ` [Qemu-devel] [PULL] Remove unused function parameters Stefan Weil
2011-04-20 10:53 ` Aurelien Jarno
2011-04-20 10:57 ` Peter Maydell
2011-04-18 16:39 ` [Qemu-devel] [PATCH 2/2] Remove unused function parameter from cpu_restore_state Stefan Weil
2011-04-18 17:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim_d=CWShjgsSn7hKNo5AYqCHZAAQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).