From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QMdi6-0004KB-9g
	for qemu-devel@nongnu.org; Wed, 18 May 2011 06:10:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QMdi5-0000LA-CB
	for qemu-devel@nongnu.org; Wed, 18 May 2011 06:10:34 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:62340)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QMdi5-0000L5-9C
	for qemu-devel@nongnu.org; Wed, 18 May 2011 06:10:33 -0400
Received: by gyg4 with SMTP id 4so548005gyg.4
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 03:10:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1305661431-21289-11-git-send-email-jvrao@linux.vnet.ibm.com>
References: <1305661431-21289-1-git-send-email-jvrao@linux.vnet.ibm.com>
	<1305661431-21289-11-git-send-email-jvrao@linux.vnet.ibm.com>
Date: Wed, 18 May 2011 11:10:32 +0100
Message-ID: <BANLkTimasj0Y534deaqFFftE0KxrLM7YqQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [V2 10/25] hw/9pfs: Update v9fs_readdir to use
	coroutines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV)
<jvrao@linux.vnet.ibm.com> wrote:
> -/* Size of each dirent on the wire: size of qid (13) + size of offset (8=
)
> +/*
> + * Size of each dirent on the wire: size of qid (13) + size of offset (8=
)
> =A0* size of type (1) + size of name.size (2) + strlen(name.data)
> =A0*/
> -#define V9_READDIR_DATA_SZ (24 + strlen(vs->name.data))
> +#define V9_READDIR_DATA_SZ (24 + strlen(name.data))

This should look like a function, not like a constant:
static size_t v9fs_readdir_data_size(V9fsString *name)
{
    /*
     * Size of each dirent on the wire: size of qid (13) + size of offset (=
8)
     * size of type (1) + size of name.size (2) + strlen(name.data)
     */
    return 24 + v9fs_string_size(name);
}

Stefan