From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46581)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brillywu@gmail.com>) id 1QRKE9-0004X9-IK
	for qemu-devel@nongnu.org; Tue, 31 May 2011 04:23:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brillywu@gmail.com>) id 1QRKE7-0005b3-VY
	for qemu-devel@nongnu.org; Tue, 31 May 2011 04:23:01 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:44814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brillywu@gmail.com>) id 1QRKE7-0005am-TC
	for qemu-devel@nongnu.org; Tue, 31 May 2011 04:22:59 -0400
Received: by yib19 with SMTP id 19so2020149yib.4
	for <qemu-devel@nongnu.org>; Tue, 31 May 2011 01:22:59 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DE49DB7.30600@web.de>
References: <BANLkTimzTSU7A-b9yc9H35b1szfL4z7H-A@mail.gmail.com>
	<4DE120BE.1010602@web.de>
	<C4F7CD9A92DBFF48AD8779355CD4D7891222DD@exchsg04.s3graphics.com>
	<BANLkTi=A_6-3fRcd+LYcznZuNKmKHEVB-Q@mail.gmail.com>
	<BANLkTinL_OnO5mNc+HRHCe9=G4rpuBF++A@mail.gmail.com>
	<4DE37551.6060502@siemens.com>
	<BANLkTikq3-aSKTSGY4EdtCyF8QgHyobQsw@mail.gmail.com>
	<4DE48689.7070606@web.de>
	<BANLkTinGu5kaF=HmnRJRnsesEgTQC01_Zw@mail.gmail.com>
	<4DE49DB7.30600@web.de>
Date: Tue, 31 May 2011 16:22:59 +0800
Message-ID: <BANLkTimbpXu+bhgn4CCUZ0Ls7Q=QnxNHZw@mail.gmail.com>
From: BrillyWu <brillywu@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for
	VIA CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm@vger.kernel.org, KaryJin@viatech.com.cn, mst@redhat.com, mtosatti@redhat.com, BrillyWu@viatech.com.cn, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, avi@redhat.com

> >> Blue, this does not trigger the missing braces warning:
> >
> > Do you mean the bug is that it can not trigger missing
> braces warining?
>
> The script fails to detect missing braces as marked below.
>
> > It seems that there is no missing braces in my patch, but some
> > unnecessary braces.
>
> There are no unnecessary braces according to QEMU coding style.

Oh, I see. Thank you!

> >> +                    index = env->cpuid_xlevel;
> >> +                }
> >> +            } else
> >> +                index =  env->cpuid_xlevel;
>
> This should be:
>
>     } else {
>         index = ...
>     }
>
> >> +        }
>
> Nope, see above.

It looks that I should add the missing braces.

>
> > BTW, I have submited a patch v3 a few minutes before withou
> fixing up
> > the braces, and I have tested it with my mail client this
> time, so it
> > could be OK now.
>
> Yes, your mail client works fine as far as I can see.

Yes, you are right. It seems to be the problem of my editor.

I'll check whether other places need any brace, and then send it to
the patch v3 thread.