From: Stefan Hajnoczi <stefanha@gmail.com>
To: Brad Hards <bradh@frogmouth.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases
Date: Wed, 13 Apr 2011 13:36:55 +0100 [thread overview]
Message-ID: <BANLkTimcPxc6PSiTCPj5P6sNoPVKiNkw-Q@mail.gmail.com> (raw)
In-Reply-To: <1302687934-1287-5-git-send-email-bradh@frogmouth.net>
On Wed, Apr 13, 2011 at 10:45 AM, Brad Hards <bradh@frogmouth.net> wrote:
> Signed-off-by: Brad Hards <bradh@frogmouth.net>
> ---
> usb-linux.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
Some of these printfs look like they might be useful given that the
current USB support is known to be imperfect and frequently causes
questions from users. By changing them to DPRINTF() you are making
these message available only to developers and not users.
Any thoughts from people who use or have written the usb-linux.c code?
Stefan
next prev parent reply other threads:[~2011-04-13 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 9:45 [Qemu-devel] [PATCH 0/4] Minor USB fixes Brad Hards
2011-04-13 9:45 ` [Qemu-devel] [PATCH 1/4] usb: trivial spelling fixes Brad Hards
2011-04-13 9:45 ` [Qemu-devel] [PATCH 2/4] usb: initialise data element in Linux USB_DISCONNECT ioctl Brad Hards
2011-04-13 9:45 ` [Qemu-devel] [PATCH 3/4] usb: fix spelling errors in usb-linux.c Brad Hards
2011-04-13 9:45 ` [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases Brad Hards
2011-04-13 12:36 ` Stefan Hajnoczi [this message]
2011-04-13 12:52 ` Hans de Goede
2011-04-13 22:01 ` Brad Hards
2011-04-25 1:02 ` Brad Hards
2011-04-13 12:37 ` [Qemu-devel] [PATCH 0/4] Minor USB fixes Stefan Hajnoczi
2011-04-14 11:01 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimcPxc6PSiTCPj5P6sNoPVKiNkw-Q@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=bradh@frogmouth.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).