From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9zJZ-00071X-Fa for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9zJY-0004yY-Ly for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:36:57 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:60406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9zJY-0004yT-G3 for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:36:56 -0400 Received: by gwb19 with SMTP id 19so291354gwb.4 for ; Wed, 13 Apr 2011 05:36:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1302687934-1287-5-git-send-email-bradh@frogmouth.net> References: <1302687934-1287-1-git-send-email-bradh@frogmouth.net> <1302687934-1287-5-git-send-email-bradh@frogmouth.net> Date: Wed, 13 Apr 2011 13:36:55 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Hards Cc: qemu-devel@nongnu.org On Wed, Apr 13, 2011 at 10:45 AM, Brad Hards wrote: > Signed-off-by: Brad Hards > --- > =A0usb-linux.c | =A0 16 ++++++++-------- > =A01 files changed, 8 insertions(+), 8 deletions(-) Some of these printfs look like they might be useful given that the current USB support is known to be imperfect and frequently causes questions from users. By changing them to DPRINTF() you are making these message available only to developers and not users. Any thoughts from people who use or have written the usb-linux.c code? Stefan