From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUL8n-0008MJ-9t
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 11:57:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUL8l-00085h-2H
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 11:57:56 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:40408)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUL8k-00085M-Nf
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 11:57:54 -0400
Received: by pvg3 with SMTP id 3so323504pvg.4
	for <qemu-devel@nongnu.org>; Wed, 08 Jun 2011 08:57:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DEF8FEB.2080504@siemens.com>
References: <cover.1307542247.git.jan.kiszka@siemens.com>
	<b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com>
	<4DEF8FEB.2080504@siemens.com>
Date: Wed, 8 Jun 2011 16:57:52 +0100
Message-ID: <BANLkTimdSaO9t9AMmtiR3BP44NdXeppScg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 01/12] Add kernel header update script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

On 8 June 2011 16:06, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> + =C2=A0 =C2=A0if [ $arch =3D=3D x86 ]; then

This should be a single '=3D' -- '=3D=3D' is a bashism. The 'checkbashisms'
script (available in 'devscripts' package on debian and ubuntu)
catches this:

cam-vm-266:maverick:testing$ checkbashisms scripts/update-linux-headers.sh
possible bashism in
/home/petmay01/linaro/qemu-from-laptop/qemu/scripts/update-linux-headers.sh
line 39 (should be 'b =3D a'):
    if [ $arch =3D=3D x86 ]; then


Otherwise looks good.

-- PMM