From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWDRj-0006vT-U9 for qemu-devel@nongnu.org; Mon, 13 Jun 2011 16:09:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWDRi-0004CO-Gn for qemu-devel@nongnu.org; Mon, 13 Jun 2011 16:09:15 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:51369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWDRh-0004CE-Tx for qemu-devel@nongnu.org; Mon, 13 Jun 2011 16:09:14 -0400 Received: by qwj8 with SMTP id 8so2912155qwj.4 for ; Mon, 13 Jun 2011 13:09:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1307559319-16183-1-git-send-email-andreas.faerber@web.de> References: <4DEF2F25.5070104@redhat.com> <1307559319-16183-1-git-send-email-andreas.faerber@web.de> From: Blue Swirl Date: Mon, 13 Jun 2011 23:08:52 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v4 00/12] ISA reconfigurability v4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: hpoussin@reactos.org, qemu-devel@nongnu.org, kraxel@redhat.com On Wed, Jun 8, 2011 at 9:55 PM, Andreas F=C3=A4rber wrote: > Hey, > > I've refined the series to track the state in ISADevice and to expose it = as VMState. > Error handling has been improved, and setting the state multiple times is= no-op now. > > To read the state, I'm introducing support for bool qdev properties. > Some more qdev_prop_get_*() helpers are introduced, too. > > Still need to do some runtime testing, but I'd like to hear if this is ge= tting > mergeable now, especially wrt VMState. > > Andreas > > > Andreas F=C3=A4rber (11): > =C2=A0qdev: Add support for property type bool > =C2=A0qdev: Add helpers for reading properties > =C2=A0isa: Provide set_state callback > =C2=A0isa: Allow to un-assign I/O ports > =C2=A0isa: Allow to un-associate an IRQ I like the patches above. But I think the set_state() interface could be improved. For example, cpu_register_io_memory() gives an index which is passed to sysbus_register_mmio(). Then the board can instantiate the device at desired location without caring about the device internals. With set_state(), the device does everything. > =C2=A0parallel: Implement ISA set_state callback > =C2=A0serial: Implement ISA set_state() callback > =C2=A0fdc: Implement ISA set_state() callback > =C2=A0ide: Allow to discard I/O ports > =C2=A0ide: Implement ISA set_state() callback > =C2=A0prep: Add pc87312 Super I/O emulation > > Herv=C3=A9 Poussineau (1): > =C2=A0fdc: Parametrize ISA base, IRQ and DMA > > =C2=A0Makefile.objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | =C2=A0 =C2=A01 + > =C2=A0default-configs/ppc-softmmu.mak | =C2=A0 =C2=A02 + > =C2=A0hw/fdc.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 62 ++++-- > =C2=A0hw/hw.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 15 ++ > =C2=A0hw/ide/core.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | =C2=A0 =C2=A08 + > =C2=A0hw/ide/internal.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = | =C2=A0 =C2=A01 + > =C2=A0hw/ide/isa.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| =C2=A0 32 +++- > =C2=A0hw/isa-bus.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| =C2=A0 57 +++++ > =C2=A0hw/isa.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A06 + > =C2=A0hw/parallel.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | =C2=A0 69 ++++-- > =C2=A0hw/pc87312.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| =C2=A0470 +++++++++++++++++++++++++++++++++++++++ > =C2=A0hw/qdev-properties.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2= =A0 88 ++++++++ > =C2=A0hw/qdev.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 | =C2=A0 13 + > =C2=A0hw/serial.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 | =C2=A0 30 ++- > =C2=A014 files changed, 803 insertions(+), 51 deletions(-) > =C2=A0create mode 100644 hw/pc87312.c > > -- > 1.7.5.3 > > >