From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roytam@gmail.com>) id 1QWhnD-0001UQ-J7
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 00:33:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roytam@gmail.com>) id 1QWhnB-00069n-LK
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 00:33:27 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:48480)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roytam@gmail.com>) id 1QWhnB-00069g-7F
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 00:33:25 -0400
Received: by wwj40 with SMTP id 40so27339wwj.10
	for <qemu-devel@nongnu.org>; Tue, 14 Jun 2011 21:33:23 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1308019077-61957-24-git-send-email-andreas.faerber@web.de>
References: <1308019077-61957-1-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-2-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-3-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-4-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-5-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-6-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-7-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-8-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-9-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-10-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-11-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-12-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-13-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-14-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-15-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-16-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-17-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-18-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-19-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-20-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-21-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-22-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-23-git-send-email-andreas.faerber@web.de>
	<1308019077-61957-24-git-send-email-andreas.faerber@web.de>
From: Roy Tam <roytam@gmail.com>
Date: Wed, 15 Jun 2011 12:33:03 +0800
Message-ID: <BANLkTimfJhP2KPmvVvyo1eTFGiMJLg0vew@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 23/23] 40p: Add an 8514/A graphics card
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, qemu-devel@nongnu.org

Hi all,

2011/6/14 Andreas F=E4rber <andreas.faerber@web.de>:
> The IBM E15 is equivalent to an S3 Vision864.
>
> Lacking S3 SDAC (86C716) support, the DAC indizes are translated
> to greyscale colors. This works sufficiently to observe firmware
> boot progress.
>

IMO we can generalize it as a generic S3 Vision864 and use it in x86 guest =
too.
http://wiki.qemu.org/Google_Summer_of_Code_2011#Add_a_S3_Trio_or_S3_Virge
CC: Natalia Portillo <claunia@claunia.com>

> Cc: Herv=E9 Poussineau <hpoussin@reactos.org>
>
> Fixed off-by-one drawing issue.
> Replaced hardcoded color for RECT.
> Separate I/O debug output for readability.
>
> Signed-off-by: Andreas F=E4rber <andreas.faerber@web.de>
> ---
> =A0Makefile.objs =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01 +
> =A0default-configs/ppc-softmmu.mak | =A0 =A01 +
> =A0hw/pci_ids.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A03 +
> =A0hw/ppc_prep.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +
> =A0hw/vga-s3.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0694 +++++++++=
++++++++++++++++++++++++++++++
> =A05 files changed, 701 insertions(+), 0 deletions(-)
> =A0create mode 100644 hw/vga-s3.c
>
[snip]

IMO using vga-s3-864.c as the file name may be better as S3 produced
many display chips.