From: Stefan Hajnoczi <stefanha@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Optimize screendump
Date: Mon, 20 Jun 2011 16:39:35 +0100 [thread overview]
Message-ID: <BANLkTimfkTm2fTLkDT5aJuEhX6hF5zADPg@mail.gmail.com> (raw)
In-Reply-To: <1308557567-27600-1-git-send-email-avi@redhat.com>
On Mon, Jun 20, 2011 at 9:12 AM, Avi Kivity <avi@redhat.com> wrote:
> When running kvm-autotest, fputc() is often the second highest (sometimes #1)
> function showing up in a profile. This is due to fputc() locking the file
> for every byte written.
>
> Optimize by buffering a line's worth of pixels and writing that out in a
> single call.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>
> v2: drop unportable fputc_unlocked
>
> hw/vga.c | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-06-20 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:12 [Qemu-devel] [PATCH v2] Optimize screendump Avi Kivity
2011-06-20 12:33 ` Jan Kiszka
2011-06-20 13:11 ` Avi Kivity
2011-06-22 21:22 ` Andreas Färber
2011-06-26 17:52 ` Blue Swirl
2011-06-20 15:39 ` Stefan Hajnoczi [this message]
2011-06-22 12:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimfkTm2fTLkDT5aJuEhX6hF5zADPg@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).