From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV5Gl-0002Wi-Gl
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 13:13:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV5Gj-0003Ib-Un
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 13:13:15 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:51329)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV5Gj-0003IU-H5
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 13:13:13 -0400
Received: by pvg3 with SMTP id 3so1386345pvg.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jun 2011 10:13:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5927cd5a12edfaef558e77c5078f79ce9f22397e.1307014902.git.quintela@redhat.com>
References: <cover.1307014902.git.quintela@redhat.com>
	<5927cd5a12edfaef558e77c5078f79ce9f22397e.1307014902.git.quintela@redhat.com>
Date: Fri, 10 Jun 2011 18:13:11 +0100
Message-ID: <BANLkTimgZeyu+q4z9rH-osEnqsgKigoKyQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 12/14] linux-user: syscall should use
 sanitized arg1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 2 June 2011 12:53, Juan Quintela <quintela@redhat.com> wrote:
> Looking at the other architectures, we should be using "how" not "arg1".
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

OK as far as it goes, but I think we should also change the
  int how = arg1;

to just 'int how;' while we're cleaning up this chunk of code.

-- PMM